[llvm-commits] [llvm] r58512 - /llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h

[Dan Gohman]

I'd rather not add more build flavors. I think
it would be sufficient to disable most of the
setSubgraphColor code by default but enabled
by an llc command-line option.

Dan

On Oct 31, 2008, at 9:51 AM, Evan Cheng wrote:

> Do we want another configure script --enable-visualization which
> enables this along with the visualization code?
>
> Evan
>
> On Oct 31, 2008, at 9:12 AM, Dan Gohman wrote:
>
>> Author: djg
>> Date: Fri Oct 31 11:12:56 2008
>> New Revision: 58512
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=58512&view=rev
>> Log:
>> Totally disable the setSubgraphColor calls temporarily, as they're
>> currently troublesome even for #ifndef NDEBUG builds.
>>
>> Modified:
>>   llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h
>>
>> Modified: llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h?rev=58512&r1=58511&r2=58512&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h (original)
>> +++ llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h Fri Oct 31
>> 11:12:56 2008
>> @@ -180,7 +180,7 @@
>>    // Skip already selected nodes.
>>    if (isSelected(Node->getNodeId()))
>>      continue;
>> -#ifndef NDEBUG
>> +#if 0
>>    DAG.setSubgraphColor(Node, "red");
>> #endif
>>    SDNode *ResNode = Select(SDValue(Node, 0));
>> @@ -190,7 +190,7 @@
>>      continue;
>>    // Replace node.
>>    if (ResNode) {
>> -#ifndef NDEBUG
>> +#if 0
>>      DAG.setSubgraphColor(ResNode, "yellow");
>>      DAG.setSubgraphColor(ResNode, "black");
>> #endif
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits