[llvm-commits] PATCH: Add Version.h and macros

[Daniel Dunbar]

On Tue, Oct 28, 2008 at 10:26 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Oct 28, 2008, at 9:56 PM, Bill Wendling wrote:
>
> > Hi Daniel,
> >
> > This will require a bit more thought. Right now, we generate Version.h
> > when doing an Apple-style build. It looks like:
> >
> >       #define LLVM_VERSION        1234
> >       #define LLVM_MINOR_VERSION     3
> >
> > This patch would conflict. I would like to get Devang's input on this.
> > It's possible that a scheme can be developed that will kill two birds
> > with one stone. :-)
>
> Yeah, Bill's right, it would be good to unify these.


Ok.


>
> Also, it seems that it would be reasonable to use make something like:
>
> #define LLVM_RELEASE_VERSION 24
>
> For LLVM 2.4 etc?  Is there any specific reason to track branches?


No, there is no particular reason to track branches (especially if
LLVM_API_VERSION is adopted). I thought it might make sense to provide the
full information given by the PACKAGE_VERSION define autoconf generates. I
don't see any particular reason not to provide it.

As far as LLVM_RELEASE_VERSION, I prefer to encode major and minor. What is
LLVM_RELEASE_VERSION 210?

 - Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20081028/c25c7bcd/attachment.html>