[llvm-commits] [llvm] r57925 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp test/CodeGen/X86/pr2924.ll

[Tomas Lindquist Olsen]

On Wed, Oct 22, 2008 at 7:23 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Oct 22, 2008, at 1:15 AM, Tomas Lindquist Olsen wrote:
>
> On Tue, Oct 21, 2008 at 10:00 PM, Dan Gohman <gohman at apple.com> wrote:
>
>> Author: djg
>> Date: Tue Oct 21 15:00:42 2008
>> New Revision: 57925
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=57925&view=rev
>> Log:
>> Fix SelectionDAGBuild lowering of Select instructions to
>> handle first-class aggregate values. Also, fix a bug in
>> the Ret handling for empty aggregates.
>>
>> Added:
>>    llvm/trunk/test/CodeGen/X86/pr2924.ll
>> Modified:
>>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
>>
>>
> Any chance this will make it into the 2.4 branch ?
>
>
> If you have an example of C code that worked with llvm-gcc in 2.3 but that
> fails with llvm-gcc in 2.4, then it would be a regression and yes we would
> want to pull it in.  Otherwise unfortunately we shouldn't pull it in.
>
> -Chris
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
Ok :(

I don't have llvm-gcc, this code is generated by my D compiler.

Using first class aggregates only started working after this fix (at least
when doing optimizations, which is what produces the select inst)

Sounds like we won't be able to support the 2.4 release. Oh well...

If I do find some time for it, what kind of C/C++ code would I write to
generate something that produces first class aggregates ?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20081022/2b7a9761/attachment.html>