[llvm-commits] [llvm] r57846 - in /llvm/trunk: include/llvm/System/Memory.h lib/System/Unix/Memory.inc lib/System/Win32/Memory.inc lib/Target/ARM/ARMJITInfo.cpp

[Duncan Sands]

Hi Jim,

> The ifdef here isn't strictly necessary, regardless, as you point out.  
> Not something I feel strongly about at all. Prefer having it always  
> execute?

personally I'd prefer to have it always execute.

Ciao,

Duncan.

> > +#if defined(__APPLE__)
> > +  ok = sys::Memory::setRangeExecutable ((void*)StubAddr, 8);
> > +  if (!ok)
> > +    {
> > +      cerr << "ERROR: Unable to mark stub executable\n";
> > +      abort();
> > +    }
> > +#endif
> >
> > After all, the functions complete successfully on non-__APPLE__
> > platforms.
> >
> > Ciao,
> >
> > Duncan.
> 
>