[llvm-commits] [llvm] r57786 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Bill Wendling]

On Mon, Oct 20, 2008 at 8:51 AM, Dan Gohman <gohman at apple.com> wrote:
> On Sun, October 19, 2008 1:51 pm, Bill Wendling wrote:
>> Author: void
>> Date: Sun Oct 19 15:51:12 2008
>> New Revision: 57786
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=57786&view=rev
>> Log:
>> Set N->OperandList to 0 after deletion. Otherwise, it's possible that it
>> will
>> be either deleted or referenced afterwards.
>
> Hi Bill,
>
> Is this addressing an actual bug?  Both of the changes are
> modifying fields of objects immediately before they are
> deallocated, so if there is code somewhere else that is using
> uninitialized SDNode fields, we should fix that code,
> regardless of this change.
>
Hi Dan,

It's not a bug that showed up in code. I noticed it while looking at
the selection DAG stuff. It's just a sanity check, basically. I'm
hoping that if anything (later on) does use these fields then a
segfault will occur.

-bw