[llvm-commits] [llvm] r56930 - /llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

[Dan Gohman]

On Oct 4, 2008, at 1:29 PM, Chris Lattner wrote:

>
> On Oct 1, 2008, at 1:39 PM, Dan Gohman wrote:
>
>> +// Enable or disable FastISel. Both options are needed, because
>> +// FastISel is enabled by default with -fast, and we wish to be
>> +// able to enable or disable fast-isel independently from -fast.
>> +static cl::opt<bool>
>> +EnableFastISelOption("fast-isel", cl::Hidden,
>> +  cl::desc("Enable the experimental \"fast\" instruction  
>> selector"));
>> +static cl::opt<bool>
>> +DisableFastISelOption("disable-fast-isel", cl::Hidden,
>> +  cl::desc("Disable the experimental \"fast\" instruction  
>> selector"));
>
> This seems like it should be a tri-state/enum option, not two  
> different and mutually conflicting options.

Aha, there's even a boolOrDefault tri-state option parser
already available. I've removed -disable-fast-isel in
favor of this. Thanks!

Dan