[llvm-commits] [poolalloc] r57214 - /poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp

[Andrew Lenharth]

On Tue, Oct 7, 2008 at 8:18 AM, Andrew Lenharth <andrewl at lenharth.org> wrote:
> On Tue, Oct 7, 2008 at 3:04 AM, Duncan Sands <baldrick at free.fr> wrote:
>>> +  CallSite(NewCall).setCallingConv(CallSite(TheCall).getCallingConv());
>>
>> Don't forget tail call markings and parameter attributes.
>
> Thanks, the tail call markings I was still looking into. The parameter
> attributes are handled during the function clone/rewriting (but suffer
> from potential off by one errors, parameter attributes should really
> be properties of the Argument class rather than positional in the
> Function class).

Actually, it's not clear, does one have to specify parameter
attributes on the call site too?  I was under the impression they just
were for the functions.  hmm...

Andrew