[llvm-commits] [llvm] r56546 - /llvm/trunk/lib/Transforms/Scalar/CodeGenPrepare.cpp

[Chris Lattner]

On Oct 4, 2008, at 3:19 PM, Eric Christopher wrote:

>
> On Oct 4, 2008, at 12:17 PM, Chris Lattner wrote:
>
>> On Sep 23, 2008, at 10:32 PM, Eric Christopher wrote:
>>
>>> Author: echristo
>>> Date: Wed Sep 24 00:32:41 2008
>>> New Revision: 56546
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=56546&view=rev
>>> Log:
>>> Fix fallout in CodeGenPrepare from 56526. Will likely need more  
>>> work.
>>
>> Hi Eric,
>>
>> What is this doing?  There is no testcase, and the "stripping  
>> trailing whitespace" thing your editor does makes the patch  
>> incredibly noisy.
>
> It was fixing up part of a missed commit that Evan had done - this  
> file didn't get committed. This worked around the issue until evan  
> fixed it back up the next day without reverting his patch completely.

ah ok, thanks!  Please try not to strip trailing whitespace in a patch  
that makes other changes.

-Chris