[llvm-commits] Struct-handling patches

[Chris Lattner]

On Sep 28, 2008, at 12:04 PM, Matthijs Kooijman wrote:

> Hi all,
>
> please find three patches attached. These patches fix some behaviour  
> related
> to struct transformations.

Nice!

> I was observing issues with struct alloca's not always being  
> properly split up
> by scalarrepl. Some other passes sometimes make changes that confuse
> scalarrepl, preventing it from doing its work.

Ok, definitely a problem worth tackling.

> I don't have a clear-cut testcase for this, since the issues occured  
> when
> running our own ordering of LLVM passes. Using -std-compile-opts or  
> llvm-gcc
> mostly managed to mask thes bugs by doing transformations in a  
> particular
> order. I have include small testcases with each patch, though.

IR testcases are great.

Since there has already been significant iteration on these, can you  
please post the updated patches again, preferable one per email?

Thanks Matthijs!

-Chris