[llvm-commits] [llvm] r57020 - in /llvm/trunk: include/llvm/Attributes.h lib/VMCore/Verifier.cpp

[Duncan Sands]

Hi Devang,

>    } else {
> -    Attributes ParmI = Attrs & Attribute::ReturnOnly;
> +    Attributes ParmI = Attrs & Attribute::FunctionOnly;
>      Assert1(!ParmI, "Attribute " + Attribute::getAsString(ParmI) +
>              " only applies to return values!", V);

this test should always be made, i.e. removed from the else part
and always executed.  That's because it should now also be applied
to return values.

> +  Assert1(!(FAttrs & (!Attribute::FunctionOnly)),

Shouldn't that be !(FAttrs & (~Attribute::FunctionOnly)) ?

Ciao,

Duncan.