[llvm-commits] [llvm-gcc-4.2] r56905 - in /llvm-gcc-4.2/trunk/gcc: c-common.c config/i386/darwin.h config/rs6000/darwin.h

[Devang Patel]

On Oct 1, 2008, at 9:49 AM, Anton Korobeynikov wrote:

> These patches causes breakage of llvm-gcc compilation on non-Darwin
> platform. The problem is seen during libiberty compilation: configure
> does not find stdlib.h and also other .h files. The corresponding
> lines in config.log:
>
> configure:3691: checking for stdlib.h
> configure:3704:
> /home/asl/proj/llvm/llvm-gcc-4.2/build/./prev-gcc/xgcc
> -B/home/asl/proj/llvm/llvm-gcc-4.2/build/./prev-gcc/
> -B/home/asl/proj/llvm/llvm-gcc-4.2/install/x86_64-unknown-linux-gnu/ 
> bin/
> -E  conftest.c
> cc1: warning: -Wformat-security ignored without -Wformat
> configure:3710: $? = 0
> configure: failed program was:
> | /* confdefs.h.  */
> |
> | #define PACKAGE_NAME ""
> | #define PACKAGE_TARNAME ""
> | #define PACKAGE_VERSION ""
> | #define PACKAGE_STRING ""
> | #define PACKAGE_BUGREPORT ""
> | /* end confdefs.h.  */
> | #include <stdlib.h>
>
> Please investigate

Sorry for the breakage. Would it be possible for you to try following  
patch? If it works, pl. apply.
Thanks,

-
Devang


Index: c.opt
===================================================================
--- c.opt       (revision 56899)
+++ c.opt       (working copy)
@@ -238,7 +238,7 @@ Warn about format strings that are not l

  ; APPLE LOCAL begin default to Wformat-security 5764921
  Wformat-security
-C ObjC C++ ObjC++ Var(warn_format_security) Init(1)
+C ObjC C++ ObjC++ Var(warn_format_security) Init(0)
  Warn about possible security problems with format functions
  ; APPLE LOCAL end default to Wformat-security 5764921

Index: config/i386/darwin.h
===================================================================
--- config/i386/darwin.h        (revision 56905)
+++ config/i386/darwin.h        (working copy)
@@ -102,7 +102,7 @@ Boston, MA 02110-1301, USA.  */
    "/* APPLE LOCAL ignore -mcpu=G4 -mcpu=G5 */"\
    %<faltivec %<mno-fused-madd %<mlong-branch %<mlongcall %<mcpu=G4  
%<mcpu=G5 \
    "/* APPLE LOCAL enable format security warnings */"\
-  %{!Wno-format:-Wformat} \
+  %{!Wno-format:-Wformat -Wformat-security} \
    %{g: %{!fno-eliminate-unused-debug-symbols: -feliminate-unused- 
debug-symbols }}"

  /* APPLE LOCAL AltiVec */
Index: config/rs6000/darwin.h
===================================================================
--- config/rs6000/darwin.h      (revision 56905)
+++ config/rs6000/darwin.h      (working copy)
@@ -114,7 +114,7 @@
    "/* APPLE LOCAL ARM 5683689 */"\
    %{!mmacosx-version-min=*: %{!miphoneos-version-min=*: % 
(darwin_cc1_minversion)}} \
    "/* APPLE LOCAL enable format security warnings */"\
-  %{!Wno-format:-Wformat} \
+  %{!Wno-format:-Wformat -Wformat-security} \
    "/* APPLE LOCAL -fast or -fastf or -fastcp */"\
    %{!mkernel:%{!static:%{!fast:%{!fastf:%{!fastcp:%{!mdynamic-no- 
pic:-fPIC}}}}}}"