[llvm-commits] [llvm] r56885 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86Subtarget.cpp lib/Target/X86/X86Su

[Bill Wendling]

On Tue, Sep 30, 2008 at 4:13 PM, Evan Cheng <evan.cheng at apple.com> wrote:
> Actually no.  It's a terrible idea. :-)
>
Aw! My sycophantic message didn't work. :-)

> This logic should not be in codegen at all. Users can still right
> __builtin_memcpy and those can be optimized with -fno-builtin.
>
> So correct solution, take two. :-) FE should not generate calls to
> @llvm.memset.i32 etc. when -fno-builtin is specified. Instead, it
> should generate a simple call to memset. So the only changes required
> are in the FE, LLVM should not know anything about -fno-builtin at
> all. That is, unless simplifylibcall decides to turn memset into
> @llvm.memset*.
>
Yes. This sounds much more sane. I'll check on the SimplifyLibCall dealy.

-bw