[llvm-commits] [llvm] r56885 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86Subtarget.cpp lib/Target/X86/X86Su

[Bill Wendling]

On Tue, Sep 30, 2008 at 3:19 PM, Dan Gohman <gohman at apple.com> wrote:
>
> Before we charge ahead with this, can we take a moment and consider
> whether it's desireable? This is giving -fno-builtin a significantly
> different meaning from what it has in GCC.
>
To address the idea of compiler-generated calls, how about this scheme:

- If the user calls `memset', the F.E. generates a call to `@memset'
when -no-builtin is set, and
- If the compiler calls `memset', it would generate a call to `@llvm.memset'

?

Then when transforming memset, we can tell the difference (under the
NoBuiltin flag) between a compiler-generated and user-generated memset
call. (This would apply analogously to other functions.)

We would have to be careful about transforming `@llvm.foo' into `@foo'
though, as `foo' might actually change if the user supplies their own
version of `foo'.

-bw