[llvm-commits] [llvm] r56569 - /llvm/trunk/lib/Target/PIC16/PIC16AsmPrinter.cpp

[Bill Wendling]

Hi Anton,

One of your recent changes is causing a build failure. Please
investigate. Thanks!

-bw

llvm[2]: ======= Finished Linking Release Executable opt (without symbols)
if [ ! -f llvm-nm/Makefile ]; then \
	  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/autoconf/mkinstalldirs
llvm-nm; \
	  /bin/cp /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/tools/llvm-nm/Makefile
llvm-nm/Makefile; \
	fi; \
	make -C llvm-nm all
Undefined symbols:
  "llvm::ARMTargetAsmInfo<llvm::TargetAsmInfo>::getInlineAsmLength(char
const*) const", referenced from:
      vtable for llvm::ARMTargetAsmInfo<llvm::TargetAsmInfo>in LLVMARMCodeGen.o
  "llvm::X86TargetAsmInfo<llvm::TargetAsmInfo>::ExpandInlineAsm(llvm::CallInst*)
const", referenced from:
      vtable for llvm::X86COFFTargetAsmInfoin LLVMX86CodeGen.o
      vtable for llvm::X86TargetAsmInfo<llvm::TargetAsmInfo>in LLVMX86CodeGen.o
      vtable for llvm::X86WinTargetAsmInfoin LLVMX86CodeGen.o
ld: symbol(s) not found
collect2: ld returned 1 exit status


On Wed, Sep 24, 2008 at 3:11 PM, Anton Korobeynikov <asl at math.spbu.ru> wrote:
> Author: asl
> Date: Wed Sep 24 17:11:26 2008
> New Revision: 56569
>
> URL: http://llvm.org/viewvc/llvm-project?rev=56569&view=rev
> Log:
> Remove dead code for PIC16 (preparation to switch to new section handling stuff)
>
> Modified:
>    llvm/trunk/lib/Target/PIC16/PIC16AsmPrinter.cpp
>
> Modified: llvm/trunk/lib/Target/PIC16/PIC16AsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PIC16/PIC16AsmPrinter.cpp?rev=56569&r1=56568&r2=56569&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/PIC16/PIC16AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/PIC16/PIC16AsmPrinter.cpp Wed Sep 24 17:11:26 2008
> @@ -416,10 +416,7 @@
>           (I->hasInternalLinkage() || I->hasWeakLinkage() ||
>            I->hasLinkOnceLinkage() || I->hasCommonLinkage())) {
>         if (Size == 0) Size = 1;   // .comm Foo, 0 is undefined, avoid it.
> -        if (!NoZerosInBSS && TAI->getBSSSection())
> -          SwitchToDataSection(M.getModuleIdentifier().c_str(), I);
> -        else
> -          SwitchToDataSection(TAI->getDataSection(), I);
> +        SwitchToDataSection(M.getModuleIdentifier().c_str(), I);
>         if (TAI->getLCOMMDirective() != NULL) {
>           if (I->hasInternalLinkage()) {
>             O << TAI->getLCOMMDirective() << name << "," << Size;
> @@ -450,13 +447,6 @@
>       // FALL THROUGH
>
>     case GlobalValue::InternalLinkage:
> -      if (I->isConstant()) {
> -        const ConstantArray *CVA = dyn_cast<ConstantArray>(C);
> -        if (TAI->getCStringSection() && CVA && CVA->isCString()) {
> -          SwitchToDataSection(TAI->getCStringSection(), I);
> -          break;
> -        }
> -      }
>       break;
>
>     default:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>