[llvm-commits] [llvm] r56524 - in /llvm/trunk: include/llvm/Attributes.h include/llvm/Function.h lib/AsmParser/llvmAsmParser.cpp.cvs lib/AsmParser/llvmAsmParser.y lib/AsmParser/llvmAsmParser.y.cvs lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp lib/Target/X86/AsmPrinter/X86IntelAsmPrinter.cpp lib/Transforms/IPO/InlineAlways.cpp lib/Transforms/IPO/InlineSimple.cpp lib/Transforms/IPO/Inliner.cpp lib/Transforms/Scalar/LoopUnswitch.cpp lib/Transforms/Utils/InlineCost.cpp lib/VMCore/AsmWriter.cpp

[Duncan Sands]

Hi,

> Eww, please introduce a new namespace.  Like "FnAttr::NoInline".  I  
> still don't understand how notes are different than attributes.  These  
> are just function attributes, no?

if I understand right, the difference between function attributes and
function notes, is that function attributes can go on calls too.  Then
as far as I can see noinline and inlinealways should be attributes,
and opt-size should be a note.  If codegen notes are introduced
(eg: compile this routine with a frame pointer) then they too would
only make sense as notes, not attributes.

On the other hand, for simplicity it might not be worth making this
distinction.

Ciao,

Duncan.