[llvm-commits] [llvm] r55745 - /llvm/trunk/lib/Transforms/IPO/Inliner.cpp

[Chris Lattner]

>> I disagree. If the programmer did not want F to get very big then he
>> should not use -O3 to compiler F.

I agree with Devang here, if a function is compiled at -O3, the  
inliner should try to inline *into* it, even if it may grow that  
function.  If a function is compiled with -Os, the compiler should  
avoid growing that function.

Devang, please make sure this is spelled out clearly in LangRef

>>
> Well, maybe.  People doing LTO might be surprised that the routines
> they carefully compiled originally using -Os have grown jumbo-sized
> in the final bitcode.

Normal people use -Os or -O3 for their whole program :).  I don't  
think there are any existing programs using the gnu toolchain that  
would have this problem.

> So I think in fact there is no issue here after all!

Even better :)

-Chris