[llvm-commits] [llvm] r56189 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/ lib/Target/ARM/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/X86/

Dan Gohman gohman at apple.com
Thu Sep 18 11:06:48 PDT 2008


On Sep 15, 2008, at 11:54 AM, Chris Lattner wrote:

>
> On Sep 13, 2008, at 10:58 AM, Dan Gohman wrote:
>
>> Author: djg
>> Date: Sat Sep 13 12:58:21 2008
>> New Revision: 56189
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=56189&view=rev
>> Log:
>> Remove isImm(), isReg(), and friends, in favor of
>> isImmediate(), isRegister(), and friends, to avoid confusion
>> about having two different names with the same meaning. I'm
>> not attached to the longer names, and would be ok with
>> changing to the shorter names if others prefer it.
>
> Thanks for doing this Dan, but could you go the other way?  The short
> names are just as legible and are more concise.  I started converting
> all the old ones over to the short ones before but apparently got
> distracted and never finished, :(

Ok, I'll change the code to the shorter names.

Dan




More information about the llvm-commits mailing list