[llvm-commits] llvm bitcode change for review or commit

[Dan Gohman]

Hi Preston,

This looks good to me. I've committed it, with a few trivial
comment changes.

Thanks,

Dan

On Sep 15, 2008, at 12:25 PM, Preston Gurd wrote:

> Re-enables the new vector select in the bitcode reader, by modifying  
> the
> bitcode reader/writer as follows:
>
> - add and use new bitcode FUNC_CODE_INST_VSELECT to handle the llvm
> select opcode using either i1 or [N x i1] as the selector.
> - retain old BITCODE FUNC_CODE_INST_SDELECT in the bitcode reader to
> handle select on i1 for backwards compatibility with existing bitcode
> files.
> - re-enable the vector-select.ll test program.
>
> Also, rename the recently added bitcode opcode FUNC_CODE_INST_VCMP to
> FUNC_CODE_INST_CMP2 and make the bitcode writer use it to handle
> fcmp/icmp on scalars or vectors. In the bitcode writer, use
> FUNC_CODE_INST_CMP for vfcmp/vicmp only. In the bitcode reader, have
> FUNC_CODE_INST_CMP handle icmp/fcmp returning bool, for backwards
> compatibility with existing bitcode files.
>
> Could someone please review these changes and either advise me what
> additional changes you might want or else commit the patch for me?
>
> Thanks,
>
> Preston Gurd
> <llvm.diff>