[llvm-commits] [llvm] r56029 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Dan Gohman]

Author: djg
Date: Tue Sep  9 18:05:00 2008
New Revision: 56029

URL: http://llvm.org/viewvc/llvm-project?rev=56029&view=rev
Log:
Change -fast-isel-no-abort to -fast-isel-abort, which now defaults
to being off by default. Also, add assertion checks to check that
the various fast-isel-related command-line options are only used
when -fast-isel itself is enabled.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=56029&r1=56028&r2=56029&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Tue Sep  9 18:05:00 2008
@@ -64,9 +64,8 @@
           cl::desc("Enable verbose messages in the experimental \"fast\" "
                    "instruction selector"));
 static cl::opt<bool>
-DisableFastISelAbort("fast-isel-no-abort", cl::Hidden,
-          cl::desc("Use the SelectionDAGISel when \"fast\" instruction "
-                   "selection fails"));
+EnableFastISelAbort("fast-isel-abort", cl::Hidden,
+          cl::desc("Enable abort calls when \"fast\" instruction fails"));
 static cl::opt<bool>
 SchedLiveInCopies("schedule-livein-copies",
                   cl::desc("Schedule copies of livein registers"),
@@ -287,6 +286,12 @@
 }
 
 bool SelectionDAGISel::runOnFunction(Function &Fn) {
+  // Do some sanity-checking on the command-line options.
+  assert((!EnableFastISelVerbose || EnableFastISel) &&
+         "-fast-isel-verbose requires -fast-isel");
+  assert((!EnableFastISelAbort || EnableFastISel) &&
+         "-fast-isel-abort requires -fast-isel");
+
   // Get alias analysis for load/store combining.
   AA = &getAnalysis<AliasAnalysis>();
 
@@ -747,11 +752,11 @@
           // feed PHI nodes in successor blocks.
           if (isa<TerminatorInst>(BI))
             if (!HandlePHINodesInSuccessorBlocksFast(LLVMBB, F)) {
-              if (EnableFastISelVerbose || !DisableFastISelAbort) {
+              if (EnableFastISelVerbose || EnableFastISelAbort) {
                 cerr << "FastISel miss: ";
                 BI->dump();
               }
-              if (!DisableFastISelAbort)
+              if (EnableFastISelAbort)
                 assert(0 && "FastISel didn't handle a PHI in a successor");
             }
 
@@ -778,11 +783,11 @@
           // Otherwise, give up on FastISel for the rest of the block.
           // For now, be a little lenient about non-branch terminators.
           if (!isa<TerminatorInst>(BI) || isa<BranchInst>(BI)) {
-            if (EnableFastISelVerbose || !DisableFastISelAbort) {
+            if (EnableFastISelVerbose || EnableFastISelAbort) {
               cerr << "FastISel miss: ";
               BI->dump();
             }
-            if (!DisableFastISelAbort)
+            if (EnableFastISelAbort)
               // The "fast" selector couldn't handle something and bailed.
               // For the purpose of debugging, just abort.
               assert(0 && "FastISel didn't select the entire block");