[llvm-commits] [llvm] r55997 - in /llvm/trunk: include/llvm/GlobalAlias.h lib/Linker/LinkModules.cpp lib/VMCore/Globals.cpp

[Anton Korobeynikov]

Hi, Duncan

> is anyone likely to want traverseWeak = true?
Yes, we even already have such uses :)

>  Isn't it basically
> always going to be wrong to follow weak aliases?
It depends on what we want to obtain. For example inside JIT we should
traverse through weak aliases as well in order to grab the address of
global. Also, stuff emitting thread local variables traverse weak
aliases for determining 'thread-localness" of alias: if the symbol
will be overridden with something non-thread-local, redundant thread
local operations won't hurt (they can only make stuff a bit slower),
but if we'll stop at weak alias, we will always emit invalid
(non-thread-local) code.

Yes, these cases are weird, but I thought about potential users twice
when adding this flag :)
-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University