[llvm-commits] [llvm] r55976 - in /llvm/trunk: lib/Bitcode/Reader/BitcodeReader.cpp test/Assembler/vector-select.ll

[Dan Gohman]

Author: djg
Date: Mon Sep  8 21:08:49 2008
New Revision: 55976

URL: http://llvm.org/viewvc/llvm-project?rev=55976&view=rev
Log:
Temporarily disable vector select in the bitcode reader. The
way it handles the type of the condition is breaking plain
scalar select in the case that the value is a
forward-reference.

Modified:
    llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
    llvm/trunk/test/Assembler/vector-select.ll

Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=55976&r1=55975&r2=55976&view=diff

==============================================================================
--- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)
+++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Mon Sep  8 21:08:49 2008
@@ -1499,7 +1499,7 @@
       Value *TrueVal, *FalseVal, *Cond;
       if (getValueTypePair(Record, OpNum, NextValueNo, TrueVal) ||
           getValue(Record, OpNum, TrueVal->getType(), FalseVal) ||
-          getValue(Record, OpNum, 0 /*skip type check*/, Cond))
+          getValue(Record, OpNum, Type::Int1Ty, Cond))
         return Error("Invalid SELECT record");
 
       // select condition can be either i1 or [N x i1]

Modified: llvm/trunk/test/Assembler/vector-select.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/vector-select.ll?rev=55976&r1=55975&r2=55976&view=diff

==============================================================================
--- llvm/trunk/test/Assembler/vector-select.ll (original)
+++ llvm/trunk/test/Assembler/vector-select.ll Mon Sep  8 21:08:49 2008
@@ -1,4 +1,5 @@
 ; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep select
+; XFAIL: *
 ; rudimentary test of select on vectors returning vector of bool
 
 define <4 x i32> @foo(<4 x i32> %a, <4 x i32> %b,