[llvm-commits] [llvm] r55638 - /llvm/trunk/include/llvm/Function.h

[Anton Korobeynikov]

Hello, Devang

> +typedef unsigned FunctionNotes;
> +const FunctionNotes FP_None            = 0;
> +const FunctionNotes FP_NoInline        = 1<<0;
> +const FunctionNotes FP_AlwaysInline    = 1<<1;
> +const FunctionNotes FP_OptimizeForSize = 1<<2;
I don't see, how this differs from attribute applied to result of
function. Also, how this is connected with your proposal? From your
proposal I thought, that notes should allow users to pass arbitrary
strings to differents parts of their code,  allowing them to parse and
use them accordingly.

Are we planning to add new "type" of note here each time we need it?
This seems to be pretty inconvenient. What will happen, when we'll
have > 64 different notes, or, "variadic" notes, say "foo=N", where N
can be any integer (for example, some threshold, etc)? Are we planning
to drop "custom" notes? If yes - them now I'm just seeing duplicating
existing paramattrs functionality.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University