[llvm-commits] [llvm] r55457 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h include/llvm/Target/TargetLowering.h lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/Target/TargetSelectionDAG.td lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86Instr64bit.td lib/Target/X86/X86InstrInfo.td

[Dan Gohman]

On Aug 28, 2008, at 1:14 PM, Dale Johannesen wrote:

>
> On Aug 28, 2008, at 11:14 AMPDT, Dan Gohman wrote:
>>
>>
>> MemSDNode has a MemoryVT member. This is used for truncating
>> stores and extending loads to indicate the type of the actual
>> memory access. We don't have extending or truncating atomics,
>> so I believe it's redundant in AtomicSDNode.
>>
>> Perhaps MemoryVT could be moved out of MemSDNode and into
>> LSBaseSDNode? That would allow a new MVT member to be added
>> to AtomicSDNode without an overall size increase.
>
> Maybe, but MemoryVT kind of belongs in the MemSDNode, doesn't it?

Not necessarily. The purpose of MemoryVT is to provide the type
when it differs from what the load or store would normally have,
in the case of an extending load or truncating store.

Dan