[llvm-commits] [llvm-gcc-4.2] r55229 - in /llvm-gcc-4.2/trunk/gcc: configure configure.ac

[Bill Wendling]

I would say that --enable-checking and --enable-optimized are mutually  
exclusive by definition. --enable-checking does a lot of expensive  
checks for many of the tree accesses. In my opinion, the configure  
script should fail if both are specified. --enable-assertions is  
probably okay with both flags -- it's would essentially be a no-op  
when specified with --enable-checking.

The patch you submitted probably isn't incorrect in spirit, but it  
needs to check the correct thing for the "checkingenabled_flag"  
variable. Checking for other modes mixed in with the --enable-checking  
flag might be good as well. Though I'd get other people's opinions on  
what the correct result should be when mixing said flags.

-bw

On Aug 23, 2008, at 3:09 PM, Andrew Lenharth wrote:

> So there is --enable-optimized and --enable-checking.  What isn't
> clear is how those two should interact w.r.t. llvm buildmode.  Builds
> use to default to using release mode (without having to specify
> --enable-optimized) and --enable-checking would always use Debug mode
> (which is the behavior I restored).  Are --enable-optimized and
> --enable-checking both valid simultaniously and if so, which llvm
> buildmode should be chosen?  Should we instead add an llvm buildmode
> flag to set the buildmode when one wants to overwrite the current
> first match approach?
>
> Andrew
>
> On Sat, Aug 23, 2008 at 4:17 PM, Bill Wendling <isanbard at gmail.com>  
> wrote:
>> I have to revert this patch. See the commit message for r55256. In a
>> nutshell, it's looking for headers and libraries in the Debug
>> directory when configured with --enable-optimized.
>>
>> On Aug 22, 2008, at 10:58 PM, Andrew Lenharth wrote:
>>
>>> Author: alenhar2
>>> Date: Sat Aug 23 00:58:16 2008
>>> New Revision: 55229
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=55229&view=rev
>>> Log:
>>> --enable-checking is suppose to use the debug build
>>>
>>> Modified:
>>>   llvm-gcc-4.2/trunk/gcc/configure
>>>   llvm-gcc-4.2/trunk/gcc/configure.ac
>>>
>>> Modified: llvm-gcc-4.2/trunk/gcc/configure
>>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/configure?rev=55229&r1=55228&r2=55229&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> = 
>>> = 
>>> ====================================================================
>>> --- llvm-gcc-4.2/trunk/gcc/configure (original)
>>> +++ llvm-gcc-4.2/trunk/gcc/configure Sat Aug 23 00:58:16 2008
>>> @@ -7369,7 +7369,9 @@
>>> esac
>>>
>>> LLVMBUILDMODE=""
>>> - if test -x "$LLVMBASEPATH/Release/bin/llc$EXEEXT"; then
>>> + if test x$checkingenabled_flag != x; then
>>> +     LLVMBUILDMODE="Debug"
>>> + elif test -x "$LLVMBASEPATH/Release/bin/llc$EXEEXT"; then
>>>     LLVMBUILDMODE="Release"
>>> elif test -x "$LLVMBASEPATH/Debug/bin/llc$EXEEXT"; then
>>>     LLVMBUILDMODE="Debug"
>>>
>>> Modified: llvm-gcc-4.2/trunk/gcc/configure.ac
>>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/configure.ac?rev=55229&r1=55228&r2=55229&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> = 
>>> = 
>>> ====================================================================
>>> --- llvm-gcc-4.2/trunk/gcc/configure.ac (original)
>>> +++ llvm-gcc-4.2/trunk/gcc/configure.ac Sat Aug 23 00:58:16 2008
>>> @@ -854,7 +854,9 @@
>>> esac
>>>
>>> LLVMBUILDMODE=""
>>> - if test -x "$LLVMBASEPATH/Release/bin/llc$EXEEXT"; then
>>> + if test "x$checkingenabled_flag" != x; then
>>> +     LLVMBUILDMODE="Debug"
>>> + elif test -x "$LLVMBASEPATH/Release/bin/llc$EXEEXT"; then
>>>     LLVMBUILDMODE="Release"
>>> elif test -x "$LLVMBASEPATH/Debug/bin/llc$EXEEXT"; then
>>>     LLVMBUILDMODE="Debug"
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits