[llvm-commits] [llvm] r54907 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Nick Lewycky nicholas at mxc.ca
Sun Aug 17 13:02:02 PDT 2008


Author: nicholas
Date: Sun Aug 17 15:02:02 2008
New Revision: 54907

URL: http://llvm.org/viewvc/llvm-project?rev=54907&view=rev
Log:
Make this comment clearer. Instead of using an ambiguous ~ (not) on an icmp
predicate, swap the order of the operands.

Modified:
    llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp?rev=54907&r1=54906&r2=54907&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Sun Aug 17 15:02:02 2008
@@ -5830,7 +5830,7 @@
                             ConstantInt::get(RHSV ^ SignBit));
       }
 
-      // (icmp u/s (xor A ~SignBit), C) -> (icmp ~s/u A, (xor C ~SignBit))
+      // (icmp u/s (xor A ~SignBit), C) -> (icmp s/u (xor C ~SignBit), A)
       if (!ICI.isEquality() && (~XorCST->getValue()).isSignBit()) {
         const APInt &NotSignBit = XorCST->getValue();
         ICmpInst::Predicate Pred = ICI.isSignedPredicate()





More information about the llvm-commits mailing list