[llvm-commits] [llvm-gcc-4.2] r54260 - /llvm-gcc-4.2/trunk/gcc/c-common.c

[Mon P Wang]

Hi Duncan,

I reverted the patch.  Just to be clear, what this bug causes in llvm- 
gcc is that any call to an overloaded intrinsic based on width (char,  
short, int, etc..) should fail with the parameter mismatch error  
message.  I'm not sure why we were not hitting it before.  I need to  
take a look at which gcc is generating and why the parenthesis are  
effecting what code is generated.  Effectively, the bug when compiling  
llvm-gcc  is that !(a || b || c || d) is not the same as what is being  
generated for !(a || b) && !(c || d).

   -- Mon Ping





On Aug 1, 2008, at 1:27 AM, Duncan Sands wrote:

> Hi Mon Ping,
>
>> I completely agree with you. I view the checkin as a temporary  
>> workaround.
>> The main reason why I checked it in was that I was concerned that my
>> breaking the build is preventing other people from get any work  
>> done on
>> llvm-gcc.  I'm planning to try to figure out why the compiler is  
>> doing
>> this weekend and try to fix it. But from your email, it sounds like  
>> this
>> bug doesn't badly disrupt people's work flow. If that is the case,  
>> I don't
>> have any problem of ripping out my hack.
>
> right - since it only (apparently) impacts bootstrap, people can still
> build the compiler without your changes by disabling bootstrap.
>
> Ciao,
>
> Duncan.
>
> PS: I will try to look into it too, though for the moment I'm waiting
> for llvm.org to come back online so I can update.