[llvm-commits] [LLVMdev] address space overloading patch broke the llvm-gcc build

[Mon P Wang]

Hi,

Here is the patch to fix the llvm-gcc to create the new intrinsic  
names for the atomics.

-- Mon Ping

-------------- next part --------------
A non-text attachment was scrubbed...
Name: addr_patch
Type: application/octet-stream
Size: 13910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080730/30bb5bf9/attachment.obj>
-------------- next part --------------


On Jul 30, 2008, at 3:13 PM, Mon P Wang wrote:

>>
>>> Hi,
>>>
>>> Sorry for breakage, I'll look into this right now.  I guess llvm-gcc
>>> doesn't use llvm tablegen results to help create intrinsic names.
>>>
>>> -- Mon Ping
>>
>> It calls Intrinsic::getDeclaration.
>>
>>> On Jul 30, 2008, at 1:51 PM, Duncan Sands wrote:
>>>
>>>> Hi, I see this when building llvm-gcc on x86-32 linux:
>>>>
>>>> xgcc -Bgcc/ -B/usr/local/gnat-llvm/i686-pc-linux-gnu/bin/ -B/usr/
>>>> local/gnat-llvm/i686-pc-linux-gnu/lib/ -isystem /usr/local/gnat-
>>>> llvm/
>>>> i686-pc-linux-gnu/include -isystem /usr/local/gnat-llvm/i686-pc-
>>>> linux-gnu/sys-include -DHAVE_CONFIG_H -I. -I../../../gcc-4.2.llvm/
>>>> libgomp -I. -I../../../gcc-4.2.llvm/libgomp/config/linux/x86 -
>>>> I../../../gcc-4.2.llvm/libgomp/config/linux -I../../../ 
>>>> gcc-4.2.llvm/
>>>> libgomp/config/posix -I../../../gcc-4.2.llvm/libgomp -Wall - 
>>>> Werror -
>>>> ftls-model=initial-exec -march=i486 -pthread -mtune=i686 -O2 -g -
>>>> O2 -
>>>> MT critical.lo -MD -MP -MF .deps/critical.Tpo -c ../../../
>>>> gcc-4.2.llvm/libgomp/critical.c  -fPIC -DPIC -o .libs/critical.o
>>>> Overloaded intrinsic has incorrect suffix: '.i8'. It should be
>>>> '.i8.p0i8'
>>>> i8 (i8*, i8)* @llvm.atomic.swap.i8
>>>> Broken module found, compilation aborted!
>>>> ../../../gcc-4.2.llvm/libgomp/critical.c: In function
>>>> 'GOMP_critical_end':
>>>> ../../../gcc-4.2.llvm/libgomp/critical.c:44: internal compiler
>>>> error: Aborted
>>>>
>>>> So I guess your address space overloading patch broke llvm-gcc.
>>>>
>>>> Ciao,
>>>>
>>>> Duncan.
>>>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev