[llvm-commits] [llvm] r53379 - in /llvm/trunk: include/llvm/Support/Mangler.h lib/VMCore/Mangler.cpp

[Evan Cheng]

Author: evancheng
Date: Wed Jul  9 19:04:23 2008
New Revision: 53379

URL: http://llvm.org/viewvc/llvm-project?rev=53379&view=rev
Log:
- Replace use of std::map<std::string, ..> with StringMap. Replace use of std::map with DenseMap, std::set with SmallPtrSet. This results in minor speed up.
- Some code clean up.

Modified:
    llvm/trunk/include/llvm/Support/Mangler.h
    llvm/trunk/lib/VMCore/Mangler.cpp

Modified: llvm/trunk/include/llvm/Support/Mangler.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Mangler.h?rev=53379&r1=53378&r2=53379&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Support/Mangler.h (original)
+++ llvm/trunk/include/llvm/Support/Mangler.h Wed Jul  9 19:04:23 2008
@@ -15,8 +15,7 @@
 #define LLVM_SUPPORT_MANGLER_H
 
 #include "llvm/ADT/DenseMap.h"
-#include <map>
-#include <set>
+#include "llvm/ADT/SmallPtrSet.h"
 #include <string>
 
 namespace llvm {
@@ -49,13 +48,13 @@
   
   /// TypeMap - If the client wants us to unique types, this keeps track of the
   /// current assignments and TypeCounter keeps track of the next id to assign.
-  std::map<const Type*, unsigned> TypeMap;
+  DenseMap<const Type*, unsigned> TypeMap;
   unsigned TypeCounter;
 
   /// This keeps track of which global values have had their names
   /// mangled in the current module.
   ///
-  std::set<const GlobalValue*> MangledGlobals;
+  SmallPtrSet<const GlobalValue*, 16> MangledGlobals;
   
   /// AcceptableChars - This bitfield contains a one for each character that is
   /// allowed to be part of an unmangled name.
@@ -87,10 +86,6 @@
     return (AcceptableChars[X/32] & (1 << (X&31))) != 0;
   }
   
-  /// getTypeID - Return a unique ID for the specified LLVM type.
-  ///
-  unsigned getTypeID(const Type *Ty);
-
   /// getValueName - Returns the mangled name of V, an LLVM Value,
   /// in the current module.
   ///
@@ -105,9 +100,11 @@
   /// from getValueName.
   ///
   std::string makeNameProper(const std::string &x, const char *Prefix = "");
-  
+
 private:
-  void InsertName(GlobalValue *GV, std::map<std::string, GlobalValue*> &Names);
+  /// getTypeID - Return a unique ID for the specified LLVM type.
+  ///
+  unsigned getTypeID(const Type *Ty);
 };
 
 } // End llvm namespace

Modified: llvm/trunk/lib/VMCore/Mangler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Mangler.cpp?rev=53379&r1=53378&r2=53379&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Mangler.cpp (original)
+++ llvm/trunk/lib/VMCore/Mangler.cpp Wed Jul  9 19:04:23 2008
@@ -16,6 +16,7 @@
 #include "llvm/Module.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringExtras.h"
+#include "llvm/ADT/StringMap.h"
 using namespace llvm;
 
 static char HexDigit(int V) {
@@ -138,7 +139,7 @@
   // - If V is an intrinsic function, do not change name at all
   // - Otherwise, mangling occurs if global collides with existing name.
   if (isa<Function>(GV) && cast<Function>(GV)->isIntrinsic()) {
-    Name = GV->getName(); // Is an intrinsic function
+    Name = GV->getNameStart(); // Is an intrinsic function
   } else if (!GV->hasName()) {
     // Must mangle the global into a unique ID.
     unsigned TypeUniqueID = getTypeID(GV->getType());
@@ -154,34 +155,35 @@
   return Name;
 }
 
-void Mangler::InsertName(GlobalValue *GV,
-                         std::map<std::string, GlobalValue*> &Names) {
+static void InsertName(GlobalValue *GV, StringMap<GlobalValue*> &Names,
+                       SmallPtrSet<const GlobalValue*, 16> &MangledGlobals) {
   if (!GV->hasName())   // We must mangle unnamed globals.
     return;
 
   // Figure out if this is already used.
-  GlobalValue *&ExistingValue = Names[GV->getName()];
+  GlobalValue *&ExistingValue = Names[GV->getNameStart()];
   if (!ExistingValue) {
     ExistingValue = GV;
+    return;
+  }
+
+  // If GV is external but the existing one is static, mangle the existing one
+  if ((GV->hasExternalLinkage() || GV->hasDLLImportLinkage()) &&
+      !(ExistingValue->hasExternalLinkage()
+        || ExistingValue->hasDLLImportLinkage())) {
+    MangledGlobals.insert(ExistingValue);
+    ExistingValue = GV;
+  } else if ((GV->hasExternalLinkage() ||
+              GV->hasDLLImportLinkage()) &&
+             (ExistingValue->hasExternalLinkage() ||
+              ExistingValue->hasDLLImportLinkage()) &&
+             GV->isDeclaration() &&
+             ExistingValue->isDeclaration()) {
+    // If the two globals both have external inkage, and are both external,
+    // don't mangle either of them, we just have some silly type mismatch.
   } else {
-    // If GV is external but the existing one is static, mangle the existing one
-    if ((GV->hasExternalLinkage() || GV->hasDLLImportLinkage()) &&
-        !(ExistingValue->hasExternalLinkage()
-          || ExistingValue->hasDLLImportLinkage())) {
-      MangledGlobals.insert(ExistingValue);
-      ExistingValue = GV;
-    } else if ((GV->hasExternalLinkage() ||
-                GV->hasDLLImportLinkage()) &&
-               (ExistingValue->hasExternalLinkage() ||
-                ExistingValue->hasDLLImportLinkage()) &&
-               GV->isDeclaration() &&
-               ExistingValue->isDeclaration()) {
-      // If the two globals both have external inkage, and are both external,
-      // don't mangle either of them, we just have some silly type mismatch.
-    } else {
-      // Otherwise, mangle GV
-      MangledGlobals.insert(GV);
-    }
+    // Otherwise, mangle GV
+    MangledGlobals.insert(GV);
   }
 }
 
@@ -206,11 +208,10 @@
     
   // Calculate which global values have names that will collide when we throw
   // away type information.
-  std::map<std::string, GlobalValue*> Names;
+  StringMap<GlobalValue*> Names;
   for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I)
-    InsertName(I, Names);
+    InsertName(I, Names, MangledGlobals);
   for (Module::global_iterator I = M.global_begin(), E = M.global_end();
-       I != E;
-       ++I)
-    InsertName(I, Names);
+       I != E; ++I)
+    InsertName(I, Names, MangledGlobals);
 }