[llvm-commits] [llvm-gcc-4.2] r53073 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

Chris Lattner sabre at nondot.org
Wed Jul 2 21:07:13 PDT 2008


Author: lattner
Date: Wed Jul  2 23:07:13 2008
New Revision: 53073

URL: http://llvm.org/viewvc/llvm-project?rev=53073&view=rev
Log:
minor cleanups, no functionality change.

Modified:
    llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

Modified: llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp?rev=53073&r1=53072&r2=53073&view=diff

==============================================================================
--- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
+++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Wed Jul  2 23:07:13 2008
@@ -84,7 +84,7 @@
 //
 // LLVMValues is a vector of LLVM Values. GCC tree nodes keep track of LLVM 
 // Values using this vector's index. It is easier to save and restore the index 
-// than the LLVM Value pointer while usig PCH. 
+// than the LLVM Value pointer while using PCH. 
 
 // Collection of LLVM Values
 
@@ -238,12 +238,14 @@
   std::vector<Value *>::reverse_iterator I, E;
 
   for (I = LLVMValues.rbegin(), E = LLVMValues.rend(); I != E; ++I) {
-    if (Value *V = *I) {
-      if (isa<Constant>(V))
-        break;
-      else
-        LLVMValuesMap.erase(V);
-    }
+    Value *V = *I;
+    if (V == 0)
+      continue;
+    
+    if (isa<Constant>(V))
+      break;
+
+    LLVMValuesMap.erase(V);
   }
 
   LLVMValues.erase(I.base(), LLVMValues.end()); // Drop erased values





More information about the llvm-commits mailing list