[llvm-commits] Slot alignment

Duncan Sands baldrick at free.fr
Tue Jul 1 23:54:26 PDT 2008


Hi,

>   SDOperand SelectionDAG::CreateStackTemporary(MVT VT) {
> +  return CreateStackTemporary(VT, 1);

while it doesn't hurt to use 1, you could also use 0 here.

> +  SDOperand CreateStackTemporary(MVT VT, unsigned minAlign = 1);

Here too.

Ciao,

Duncan.

PS: Can you please include patches inline rather than
attaching them (if they are not too humungous) - that
makes it easier to add comments.  Thanks!



More information about the llvm-commits mailing list