[llvm-commits] [llvm] r52978 - in /llvm/trunk: include/llvm/Analysis/Dominators.h lib/Analysis/LoopPass.cpp lib/VMCore/PassManager.cpp

Devang Patel dpatel at apple.com
Tue Jul 1 12:50:56 PDT 2008


Author: dpatel
Date: Tue Jul  1 14:50:56 2008
New Revision: 52978

URL: http://llvm.org/viewvc/llvm-project?rev=52978&view=rev
Log:
Fix typos in comments. 
Thanks for the feedback!

Modified:
    llvm/trunk/include/llvm/Analysis/Dominators.h
    llvm/trunk/lib/Analysis/LoopPass.cpp
    llvm/trunk/lib/VMCore/PassManager.cpp

Modified: llvm/trunk/include/llvm/Analysis/Dominators.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/Dominators.h?rev=52978&r1=52977&r2=52978&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Analysis/Dominators.h (original)
+++ llvm/trunk/include/llvm/Analysis/Dominators.h Tue Jul  1 14:50:56 2008
@@ -308,7 +308,7 @@
   // FIXME: Should remove this
   virtual bool runOnFunction(Function &F) { return false; }
 
-  /// compare - Return false if the other dominator tree base maches this
+  /// compare - Return false if the other dominator tree base matches this
   /// dominator tree base. Otherwise return true.
   bool compare(DominatorTreeBase &Other) const {
 
@@ -735,7 +735,7 @@
     return DT->getRootNode();
   }
 
-  /// compare - Return false if the other dominator tree maches this
+  /// compare - Return false if the other dominator tree matches this
   /// dominator tree. Otherwise return true.
   inline bool compare(DominatorTree &Other) const {
     DomTreeNode *R = getRootNode();
@@ -949,7 +949,7 @@
   }
 
   /// compareDomSet - Return false if two domsets match. Otherwise
-  /// return ture;
+  /// return true;
   bool compareDomSet(DomSetType &DS1, const DomSetType &DS2) const {
     std::set<BasicBlock *> tmpSet;
     for (DomSetType::const_iterator I = DS2.begin(),

Modified: llvm/trunk/lib/Analysis/LoopPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LoopPass.cpp?rev=52978&r1=52977&r2=52978&view=diff

==============================================================================
--- llvm/trunk/lib/Analysis/LoopPass.cpp (original)
+++ llvm/trunk/lib/Analysis/LoopPass.cpp Tue Jul  1 14:50:56 2008
@@ -234,7 +234,7 @@
       recordAvailableAnalysis(P);
       removeDeadPasses(P, "", ON_LOOP_MSG);
 
-      // Verify dominator information if it is available and preserved.
+      // If dominator information is available then verify the info if requested.
       verifyDomInfo(*LP, F);
 
       if (skipThisLoop)

Modified: llvm/trunk/lib/VMCore/PassManager.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/PassManager.cpp?rev=52978&r1=52977&r2=52978&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/PassManager.cpp (original)
+++ llvm/trunk/lib/VMCore/PassManager.cpp Tue Jul  1 14:50:56 2008
@@ -42,7 +42,7 @@
   None, Arguments, Structure, Executions, Details
 };
 
-bool VerifyDomInfo = false;
+bool VerifyDomInfo = true;
 static cl::opt<bool,true>
 VerifyDomInfoX("verify-dom-info", cl::location(VerifyDomInfo),
                cl::desc("Verify dominator info (time consuming)"));
@@ -631,7 +631,7 @@
     cerr << "Pass " << P.getPassName() << "\n";
     cerr << "----- Valid -----\n";
     OtherDT.dump();
-    cerr << "----- InValid -----\n";
+    cerr << "----- Invalid -----\n";
     DT->dump();
     assert (0 && "Invalid dominator info");
   }
@@ -648,13 +648,13 @@
     cerr << "Pass " << P.getPassName() << "\n";
     cerr << "----- Valid -----\n";
     OtherDF.dump();
-    cerr << "----- InValid -----\n";
+    cerr << "----- Invalid -----\n";
     DF->dump();
     assert (0 && "Invalid dominator info");
   }
 }
 
-/// Remove Analyss not preserved by Pass P
+/// Remove Analysis not preserved by Pass P
 void PMDataManager::removeNotPreservedAnalysis(Pass *P) {
   AnalysisUsage AnUsage;
   P->getAnalysisUsage(AnUsage);
@@ -1250,7 +1250,7 @@
     recordAvailableAnalysis(FP);
     removeDeadPasses(FP, F.getNameStart(), ON_FUNCTION_MSG);
 
-    // Verify dominator information if it is available and preserved.
+    // If dominator information is available then verify the info if requested.
     verifyDomInfo(*FP, F);
   }
   return Changed;





More information about the llvm-commits mailing list