[llvm-commits] [llvm] r52893 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAG.h lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/Target/ARM/ARMISelLowering.cpp lib/Target/Alpha/AlphaISelLowering.cpp lib/Target/CellSPU/SPUISelLowering.cpp lib/Target/Mips/MipsISelLowering.cpp lib/Target/PIC16/PIC16ISelLowering.cpp lib/Target/PowerPC/PPCISelLowering.cpp lib/Target/Sparc/SparcISelLowering.cpp lib/Target/X86/X86ISelLowering.cpp

[Duncan Sands]

Hi Dan,

> >   // Use a MERGE_VALUES node to drop the chain result value.
> > -  return DAG.getNode(ISD::MERGE_VALUES, MVT::i64, Res).Val;
> > -}
> > +  return DAG.getMergeValues(DAG.getVTList(VT), &Res, 1, false).Val;
> > +}
> 
> As this is the one place currently that needs to pass false to
> getMergeValues, could you put a comment about it here? Something
> like "note that we need to pass false to getMergeValues to tell
> it not to just return back Res verbatim, which won't work here
> because we specifically need a node with exactly one result."

I added a (minimal) comment - r52952.

Thanks!

Duncan.