[llvm-commits] [llvm] r52747 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/X86/uint_to_fp.ll

[Duncan Sands]

Hi Chris,

> +  // If the input is a legal type, and UINT_TO_FP is not legal on this target,
> +  // but SINT_TO_FP is legal on this target, try to convert.
> +  if (TLI.isTypeLegal(OpVT) && !TLI.isOperationLegal(ISD::UINT_TO_FP, OpVT) &&
> +      TLI.isOperationLegal(ISD::SINT_TO_FP, OpVT)) {

there is no need to test for a legal type, since if the type is illegal then
isOperationLegal will return false.

Ciao,

Duncan.