[llvm-commits] [llvm] r51934 - in /llvm/trunk: include/llvm/CodeGen/LiveInterval.h include/llvm/CodeGen/LiveStackAnalysis.h include/llvm/CodeGen/MachineFrameInfo.h include/llvm/CodeGen/Passes.h lib/CodeGen/LLVMTargetMachine.cpp lib/CodeGen/LiveInterval.cpp lib/CodeGen/LiveIntervalAnalysis.cpp lib/CodeGen/LiveStackAnalysis.cpp lib/CodeGen/RegAllocLinearScan.cpp lib/CodeGen/StackSlotColoring.cpp

[Chris Lattner]

On Jun 23, 2008, at 2:06 PM, Evan Cheng wrote:
>>
>> isSS?  Why do you need this?  You're bloating all LiveInterval's  
>> for this flag.
>
> This is used in debugging dump. I have changed this to use the top  
> bit of "reg" instead.

Ok, it would be nice to add a comment saying that it is only to make  
the debugging dump prettier.

>>> +static cl::opt<int>
>>> +DeleteLimit("slot-delete-limit", cl::init(-1), cl::Hidden,
>>> +             cl::desc("Stack coloring slot deletion limit"));
>>
>> What is DeleteLimit?  Does DisableSharing disable the whole pass?
>
> This option is used to debug coloring. Once the limit is reached,  
> the rest of the slots are not colored.

Ok, so it's similar to cutting off instcombine at some point.  It  
would be nice to teach the passmgr how to do this somehow so bugpoint  
could drive it.  In the meantime, could you add a comment explaining  
more of what it is for?  ... or deleteing it is fine also. :)

-Chris