[llvm-commits] [llvm] r52315 - in /llvm/trunk: include/llvm/Analysis/ValueTracking.h lib/Analysis/ValueTracking.cpp lib/Transforms/Scalar/InstructionCombining.cpp

Matthijs Kooijman matthijs at stdin.nl
Tue Jun 17 01:30:22 PDT 2008


Hi Dan,

> Well, there's no insertvalue instruction for a constant or an undef. I
> thought of the name FindExtractedValue because it returns the value that
> an extractvalue with the given arguments would extract.
Hmm, good point. How about FindValueAtIndices?

> Also, the comment here still says FindScalarValue, and it's
> now over 80 columns.
Hmm, I had checked all my .cpp files for 80 column violations.. :-)

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080617/94b710bd/attachment.sig>


More information about the llvm-commits mailing list