[llvm-commits] [llvm] r52137 - in /llvm/trunk: lib/Transforms/IPO/IPConstantPropagation.cpp test/Transforms/IPConstantProp/2008-06-09-WeakProp.ll

[Chris Lattner]

On Jun 9, 2008, at 1:39 AM, Duncan Sands wrote:

> Hi Chris,
>
>> +  // If this function could be overridden later in the link stage,  
>> we can't
>> +  // propagate information about its results into callers.
>> +  if (F.hasLinkOnceLinkage() || F.hasWeakLinkage())
>> +    return false;
>
> what is LinkOnceLinkage?  Does this mean that places that need to
> take care with weak linkage need to worry about link once linkage
> too?  If so, perhaps there should be a method for determining if
> a function body is reliable or not.

linkonce is mostly similar to weak, but with some minor differences.   
I think having a predicate for "could be overridden" is a great idea.

-Chris