[llvm-commits] [llvm] r51806 - in /llvm/trunk: docs/LangRef.html include/llvm/Constants.h include/llvm/DerivedTypes.h include/llvm/Instructions.h lib/AsmParser/llvmAsmParser.cpp.cvs lib/AsmParser/llvmAsmParser.h.cvs lib/AsmParser/llvmAsmParser.y lib/AsmParser/llvmAsmParser.y.cvs lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/Constants.cpp lib/VMCore/Instructions.cpp lib/VMCore/Type.cpp test/Assembler/insertextractvalue.ll

[Matthijs Kooijman]

Hi Dan,

there are still some constructors missing, find a patch for them attached.

With that patch applied, I can succesfully create extractvalue and insertvalue
instructions with a single index. I only tested the InsertBefore variants, but
I guess the InsertAtEnd should work identically.

I'm not really sure if that setName should be there, it's a bit weird that one
of the init methods does set the name, but the others don't. Perhaps adding a
Name argument to all init methods is better?

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: insertextract.diff
Type: text/x-diff
Size: 2593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080602/dffcecb4/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080602/dffcecb4/attachment.sig>