[llvm-commits] [llvm] r51461 - in /llvm/trunk: include/llvm/Instructions.h lib/VMCore/Constants.cpp lib/VMCore/Instructions.cpp

[Chris Lattner]

On May 29, 2008, at 3:16 PM, Dan Gohman wrote:

>>>
>>> +  /// Constructors - These two constructors are convenience
>>> methods because one
>>> +  /// and two index insertvalue instructions are so common.
>>> +  InsertValueInst(Value *Agg, Value *Val,
>>> +                  Value *Idx, const std::string &Name = "",
>>> +                  Instruction *InsertBefore = 0);
>>> +  InsertValueInst(Value *Agg, Value *Val, Value *Idx,
>>> +                  const std::string &Name, BasicBlock  
>>> *InsertAtEnd);
>>
>> It seems these two were declared but not implemented, I will probably
>> implement these now or tomorrow, unless you do it first :-)
>
> Thanks, however I'm actually in the middle of making some significant
> changes to this code. Following on review feedback, I'm going to  
> change
> it to use compile-time constant indicies (uint64_t) instead of
> Constant*'s, and make some other changes that go along with that.

How about just using 'unsigned' instead of uint64_t?

-Chris