[llvm-commits] [llvm] r51461 - in /llvm/trunk: include/llvm/Instructions.h lib/VMCore/Constants.cpp lib/VMCore/Instructions.cpp

[Matthijs Kooijman]

Hi,

> It seems these two were declared but not implemented, I will probably
> implement these now or tomorrow, unless you do it first :-)

Attached is a small diff, which does not implements these constructors (that
would lead to a lot of duplicate code), but instead lets the
InsertValueInst::Create functions that used use another constructor instead.

This uses Value** (&Idx and &Idx + 1) as begin and end iterators which seems
to work (read: compile) but I'm not 100% sure this is the right approach. I
haven't done any runtest yet either (no more time now, and the first try was
thwarted by the wrong asserts :-)

Also, I think this needs to be done for ExtractValueInst as well.

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: insertvalue.diff
Type: text/x-diff
Size: 1746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080529/c12988fd/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080529/c12988fd/attachment.sig>