[llvm-commits] [llvm] r51590 - in /llvm/trunk/lib/VMCore: BasicBlock.cpp Instructions.cpp

[Chris Lattner]

On May 27, 2008, at 4:06 AM, Gabor Greif wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=51590&view=rev
> Log:
> prune unneeded #includes

> +++ llvm/trunk/lib/VMCore/Instructions.cpp Tue May 27 06:06:03 2008
> @@ -12,7 +12,6 @@
> //
> // 
> = 
> = 
> = 
> ----------------------------------------------------------------------= 
> ==//
>
> -#include "llvm/BasicBlock.h"

Ok.

> +++ llvm/trunk/lib/VMCore/BasicBlock.cpp Tue May 27 06:06:03 2008
> @@ -11,7 +11,6 @@
> //
> // 
> = 
> = 
> = 
> ----------------------------------------------------------------------= 
> ==//
>
> -#include "llvm/BasicBlock.h"
> #include "llvm/Constants.h"
> #include "llvm/Instructions.h"
> #include "llvm/Type.h"

Not ok.  The .cpp file for a module should include its corresponding  
header first, even if redundant.

-Chris