[llvm-commits] [llvm] r51134 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/2003-11-13-ConstExprCastCall.ll test/Transforms/InstCombine/fp-ret-bitcast.ll

[Chris Lattner]

On May 21, 2008, at 11:31 PM, Duncan Sands wrote:

>>> If it is called in several different ways in the same module then
>>> indeed
>>> there's not much you can do.  Still, I can't help feeling this
>>> transform
>>> is useful since I can imagine that quite often people have code in
>>> which
>>> some bogus declaration is used but each call calls it in the
>>> "correct" way.
>>
>> I don't see the compelling reason to do this.  What use case does it
>> help?
>
> the main reason was that it amused me to write this!  You are right
> that it is essentially useless: while it does fire during the gcc
> build, it does so very very rarely.  How about I change the  
> instcombine
> transform to only change calls when the declaration of the callee is
> visible, and leave it at that?

Seems reasonable to me.  Please watch the testers for any perf  
regressions the day after though.

-Chris