[llvm-commits] [llvm] r51356 - in /llvm/trunk: lib/Analysis/AliasSetTracker.cpp test/Transforms/LICM/2008-05-20-AliasSetVAArg.ll

Dan Gohman gohman at apple.com
Tue May 20 15:25:39 PDT 2008


On May 20, 2008, at 3:05 PM, Chris Lattner wrote:

> Author: lattner
> Date: Tue May 20 17:05:28 2008
> New Revision: 51356
>
> URL: http://llvm.org/viewvc/llvm-project?rev=51356&view=rev
> Log:
> Fix PR2346 by marking vaarg as volatile so that licm doesn't try to
> hoist them.

vaarg was already marked as ModRef; why is that not sufficient? Wouldn't
LICM have the same problem with a call that was known to ModRef a
single memory location? Claiming that vaarg is volatile seems to be
merely covering up a LICM bug.

Dan




More information about the llvm-commits mailing list