[llvm-commits] [llvm] r51132 - /llvm/trunk/lib/Support/APFloat.cpp

[Evan Cheng]

On May 15, 2008, at 6:53 AM, Neil Booth wrote:

> Evan Cheng wrote:-
>
>> Well, sorry about introducing a bug. Obviously the patch isn't  
>> intended to
>> fix a bug. It's meant to suppress compile time warnings (with -m64
>> -Wshorten-64-to-32). Unfortunately it's a strict requirement for  
>> some.
>>
>>>
>>>
>>> Could you review carefully every line of your patch to see if it
>>> hasn't introduced others, or consider reverting it?
>>
>> If you think the patch is dangerous. Please go ahead and revert  
>> APFloat.cpp
>> portion of the patch.
>
> Take responsibility for your own commits, particularly once they're
> shown to be erroneous, and don't push that burden onto others.

Please get off your high horse. LLVM community is very good at helping  
each other out. Since I don't know the code as well as you do, I'm  
simply asking you to review the patch to determine if there are  
additional issues. If you think there are other bugs introduced by  
this patch, you can revert the patch. If you don't want the *burden*,  
I'd be happy to issue the svn command to undo the damage I've caused.

Evan


>
>
> Neil.