[llvm-commits] [llvm] r50634 - in /llvm/trunk: include/llvm/Target/TargetAsmInfo.h lib/CodeGen/AsmPrinter.cpp lib/Target/TargetAsmInfo.cpp lib/Target/X86/X86Subtarget.cpp lib/Target/X86/X86Subtarget.h lib/Target/X86/X86TargetAsmInfo.cpp test/CodeGen/X86/xor_not.ll

[Chris Lattner]

On May 4, 2008, at 5:28 PM, Dan Gohman wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=50634&view=rev
> Log:
> Add AsmPrinter support for emitting a directive to declare that
> the code being generated does not require an executable stack.
>
> Also, add target-specific code to make use of this on Linux
> on x86.

Ok.

> @@ -84,7 +84,7 @@
>
> public:
>   enum {
> -    isELF, isCygwin, isDarwin, isWindows, isMingw
> +    isELF, isELFLinux, isCygwin, isDarwin, isWindows, isMingw
>   } TargetType;

Why do we need an isELFLinux target here?  Isn't "isElf && isLinux"  
acceptable?  The isLinux predicate should be orthogonal to the object  
file type as you say.

-Chris