[llvm-commits] [llvm] r49731 - in /llvm/trunk: lib/Analysis/BasicAliasAnalysis.cpp test/Analysis/BasicAA/2008-04-15-Byval.ll

[Dale Johannesen]

Author: johannes
Date: Tue Apr 15 12:41:34 2008
New Revision: 49731

URL: http://llvm.org/viewvc/llvm-project?rev=49731&view=rev
Log:
Don't assume a tail call can't reference a byval
argument to the outer function, this isn't correct.


Added:
    llvm/trunk/test/Analysis/BasicAA/2008-04-15-Byval.ll
Modified:
    llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

Modified: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=49731&r1=49730&r2=49731&view=diff

==============================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Tue Apr 15 12:41:34 2008
@@ -273,8 +273,10 @@
 
       // If this is a tail call and P points to a stack location, we know that
       // the tail call cannot access or modify the local stack.
-      if (isa<AllocaInst>(Object) ||
-          (isa<Argument>(Object) && cast<Argument>(Object)->hasByValAttr()))
+      // We cannot exclude byval arguments here; these belong to the caller of
+      // the current function not to the current function, and a tail callee
+      // may reference them.
+      if (isa<AllocaInst>(Object))
         if (CallInst *CI = dyn_cast<CallInst>(CS.getInstruction()))
           if (CI->isTailCall())
             return NoModRef;

Added: llvm/trunk/test/Analysis/BasicAA/2008-04-15-Byval.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/2008-04-15-Byval.ll?rev=49731&view=auto

==============================================================================
--- llvm/trunk/test/Analysis/BasicAA/2008-04-15-Byval.ll (added)
+++ llvm/trunk/test/Analysis/BasicAA/2008-04-15-Byval.ll Tue Apr 15 12:41:34 2008
@@ -0,0 +1,18 @@
+; RUN: llvm-as < %s | opt -std-compile-opts | llvm-dis | grep store
+; ModuleID = 'small2.c'
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
+target triple = "i386-apple-darwin8"
+	%struct.x = type { [4 x i32] }
+
+define void @foo(%struct.x* byval align 4  %X) nounwind  {
+entry:
+	%tmp = getelementptr %struct.x* %X, i32 0, i32 0		; <[4 x i32]*> [#uses=1]
+	%tmp1 = getelementptr [4 x i32]* %tmp, i32 0, i32 3		; <i32*> [#uses=1]
+	store i32 2, i32* %tmp1, align 4
+	%tmp2 = call i32 (...)* @bar( %struct.x* byval align 4  %X ) nounwind 		; <i32> [#uses=0]
+	br label %return
+return:		; preds = %entry
+	ret void
+}
+
+declare i32 @bar(...)