[llvm-commits] [test-suite] r49007 - /test-suite/trunk/Makefile.programs

[Chris Lattner]

On Mar 31, 2008, at 4:43 PM, Dale Johannesen wrote:

> Author: johannes
> Date: Mon Mar 31 18:43:08 2008
> New Revision: 49007
>
> URL: http://llvm.org/viewvc/llvm-project?rev=49007&view=rev
> Log:
> Remove -enable-eh; it is no longer required.

Shouldn't these lines actually be removed?  It seems strange to have  
them commented out like this.

I'd think something like:

# PPC and X86 support DWARF EH by default always.
ifneq ($(ARCH),PowerPC)
ifneq ($(ARCH),x86)
> LLCFLAGS += -enable-correct-eh-support
> LLVMLD_FLAGS += -disable-inlining
..
endif
endif

would work.

-Chris

>
> Modified:
>    test-suite/trunk/Makefile.programs
>
> Modified: test-suite/trunk/Makefile.programs
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/Makefile.programs?rev=49007&r1=49006&r2=49007&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- test-suite/trunk/Makefile.programs (original)
> +++ test-suite/trunk/Makefile.programs Mon Mar 31 18:43:08 2008
> @@ -321,11 +321,12 @@
> # expensive) support for it.
> ifdef REQUIRES_EH_SUPPORT
> # PPC and X86 support DWARF exceptions, for everything else, default  
> to SJLJ
> +# -enable-eh is no longer required to get DWARF exceptions.
> ifeq ($(ARCH),PowerPC)
> -LLCFLAGS += -enable-eh
> +#LLCFLAGS += -enable-eh
> else
> ifeq ($(ARCH),x86)
> -LLCFLAGS += -enable-eh
> +#LLCFLAGS += -enable-eh
> else
> LLCFLAGS += -enable-correct-eh-support
> LLVMLD_FLAGS += -disable-inlining
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits