[llvm-commits] Speeding up instruction selection

[Dan Gohman]

On Mar 30, 2008, at 11:26 AM, Chris Lattner wrote:
>
> On Mar 27, 2008, at 5:10 PM, Dan Gohman wrote:
>
>> I tested the SDNodeUses.patch and it passed. I have one comment
>> on this patch; I don't think this change:
>>
>> -  const SDOperand &getOperand(unsigned Num) const {
>> +  const SDUse &getOperand(unsigned Num) const {
>>
>> and several other related changes (getChain, getBasePtr, etc.)
>> are right. I think these should still return SDOperand references.
>> This will help keep client code more consistent. Other than that
>> I think this patch is ok to commit.
>
> Incidentally, I think it would be even better to return SDOperand by
> value.  This is a small value class, so I think it will be a win.
> What do you think?

These trivial accessor member functions ought to be inlined in any
optimized build, but I agree that it's slightly nicer to return
SDOperand by value.

Dan