[llvm-commits] [llvm] r48730 - /llvm/trunk/test/CFrontend/2008-03-24-BitFiel-And-Alloca.c

[Devang Patel]

On Mar 24, 2008, at 2:04 PM, Chris Lattner wrote:

>>> Are you testing the front-end here or the optimizer?  If you're
>>> testing the front-end, don't pass -O2.  If you're testing the
>>> optimizer, write this as a .ll file, not a .c file.
>>
>> I am testing FE and optimizer both here. One regression FE lowering
>> caused optimizer to not eliminate unnecessary alloca instructions.
>
> I haven't seen all the patches yet, is the fix in the f.e. or the
> optimizer?

magic :) !

I should have connected dots using appropriate commit messages. Sorry.

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080324/060114.html

This check-in updates lowering such that <i8, [7 x i8]> is not used to  
represent this struct, which in turns allows SRoA to eliminate allocas.

I added these lines earlier as an independent patch and the comments  
described its intent. Now, it is not clear, at least to me, whether  
bit-field types influence struct type alignment or not. When I added  
the original patch, I relied one test case which passes now. I am not  
super confident about this -- bit-field type's impact on struct  
alignment -- but now original behavior is restored.
-
Devang