[llvm-commits] [llvm] r48676 - in /llvm/trunk: include/llvm/System/Memory.h lib/System/Unix/Memory.inc lib/System/Win32/Memory.inc

Duncan Sands baldrick at free.fr
Sat Mar 22 01:02:04 PDT 2008


Hi Owen,

>  
> +      static MemoryBlock AllocateRW(unsigned NumBytes,
> +                                    const MemoryBlock *NearBlock,
> +                                    std::string *ErrMsg = 0);
> +
>        /// This method releases a block of Read/Write/Execute memory that was
>        /// allocated with the AllocateRWX method. It should not be used to
>        /// release any memory block allocated any other way.

how about having the comment explaining what it does in the header?  That means
you don't have to rootle around finding where the routine is implemented just
to find out what it is supposed to do.

Ciao,

Duncan.



More information about the llvm-commits mailing list