[llvm-commits] Patch to IfCvt

[Evan Cheng]

+  // We only have to predicate the block if we could fall through to it
+  if (!TII->BlockHasNoFallThrough(*BBI1->BB))
+    PredicateBlock(*BBI2, DI2, *Cond2);

I don't think this is the right fix. Whether the sub-cfg is a  
candidate diamond shape to be if-converted should be determined  
earlier. Also, the test is whether the true block has a fallthrough,  
which doesn't seem to match the comment. Do you have a test case in  
mind? Please file a bug or send it to me.

Thanks,

Evan

On Mar 15, 2008, at 9:20 PM, Christopher Lamb wrote:

> Is this patch safe? It passes the .dg tests and seems reasonable to  
> me, but I don't have an ARM to actually run tests on.
> --
> Christopher Lamb
>
>
> <ifcvt.patch>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits